Minor improvements to CI stability + Tracy/OOB build fix#331
Merged
Conversation
Also includes a build fix for the uncommon Tracy + OOB Check configuration
|
Check-perf-impact results: (cad5fb03670f51e00b16688b9ca8eaf9) ❓ No new benchmark data submitted. ❓ |
There was a problem hiding this comment.
Pull Request Overview
This PR improves CI stability by refining the executor progress warning suppression to only debug builds and includes a build fix for the rare Tracy + OOB-check configuration.
- Limit warning suppression to debug builds
- Fix build issue with Tracy and OOB-check configuration
Files not reviewed (2)
- src/live_executor.cc: Language not supported
- test/test_utils.cc: Language not supported
Pull Request Test Coverage Report for Build 14108846533Details
💛 - Coveralls |
Contributor
Author
Yeah I saw and looked into it a bit. Clearly non-deterministic (re-running fixes it), but no further idea as of now,. It is curious that it repeatedly only happened in the dpcpp/latest/debug config. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several recent CI debug runs failed spuriously due to the executor progress warning.
We already had code to ignore it, but it was apparently outdated (see changes).
Instead of applying the fixed version indiscriminately, it is now only applied in debug builds.
This also includes a build fix for the uncommon Tracy + OOB Check configuration as a drive-by.